Reinstate AlmaLinux images with a different versioning strategy #1613
Conversation
fdr
force-pushed
the
almalinux-again
branch
3 times, most recently
from
367906a
to
4129e1a
Compare
good catch. |
I am not sure if I understand this comment correctly. But note that the path in the rhizome side is a function of the name, and is important when operations like removing the image. |
if we have existing AlmaLinux VMs, the boot_image field may need a change, it's currently like Do you see a problem with this conflicting with legacy VMs that pre-date BootImage? Did you do some kind of backport that will be broken by it? |
Updating I was more concerned with updating |
fdr
force-pushed
the
almalinux-again
branch
3 times, most recently
from
d2dad42
to
7397d86
Compare
...hmm, well, maybe we should, but do we? aren't they busted right now, where there's no support? what does that accomplish? actually, we're a bit fuzzy on what the column on Vm does now that BootImage also exists and there's a foreign key to it via storage volumes. |
fdr
force-pushed
the
almalinux-again
branch
2 times, most recently
from
5cd7923
to
5b6c7eb
Compare
|
Requesting re-review, I didn't change a whole lot, but added almalinux-8 and phased the patches for deploy |
|
Can you add default versions here? https://github.com/ubicloud/ubicloud/blob/main/prog/download_boot_image.rb#L20 |
This is partially a revert of 69bf5c8. But it also modifies the versioning to be less specific: AlmaLinux is now requested only by its major version, e.g. "9", not "9.3". It also adds almalinux-8, for which we have some demand, and as it has similar looking URLs and considerations I thought to include it. This method is the most like Ubuntu even though it includes one less version number component. Ubuntu has releases like "22.04.3", where we never displayed the last version component. The "3" in AlmaLinux "9.3" is a similar minor version that we don't need to display while remaining consistent with Ubuntu. That I included the second digit of AlmaLinux before was a mistake I made in the most ancient era: March 2023, whereas the entire code base began in January 2023, adc109d.
After images have been downloaded onto some or all hosts, this patch permits showing these choices to the user.
|
@enescakir alright, done per the usual. Seems like there's a suboptimal amount of shotgun surgery here, but since we expect major fluctuation here as custom image support rolls in...I think I'm content to let a sleeping dog lie. |
We might reduce the number of areas we need to modify when introducing a new boot image |
Wew, don't think the juice is worth that squeeze. |
This is sort of a revert of
69bf5c8. But it also modifies the versioning to be less specific: AlmaLinux is now requested only by its major version, e.g. "9", not "9.3"
This method is the most like Ubuntu even though it includes one less version number component. Ubuntu has releases like "22.04.3", where we never displayed the last version component. The "3" in AlmaLinux "9.3" is a similar minor version that we don't need to display while remaining consistent with Ubuntu.
That I included the second digit of AlmaLinux before was a mistake I made in the most ancient era: March 2023, whereas the entire code base began in January 2023, adc109d.