Thought: Reduce demo size by 84% #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ize from 220kb to 36kb (70kb to 11kb gzipped)
|
Nice idea, but as this is a React component, I would like to keep React. It’s just a demo. If someone want’s to use Preact, they can. Maybe we can add an information that it is compatible with Preact. What do you think? |
|
Makes sense. A note in the readme or something would do, sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya! This is a great project. I was curious if it worked with Preact, so I forked it and aliased the react dependency using aliasify.
Turns out, dropping preact in as a direct replacement for React in the demo reduces the size of
app.jsfrom 220kb to 36kb! (from 70kb to 11kb gzipped!) Both gzipped and raw sizes are 84% smaller, with no change in functionality.Your demo with the change in this PR is published here if you want to check it out.