fix: use a not random id for the list #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #452, a bug where the random ID for the suggest list makes snapshot tests and enhancing server side rendered apps unusable.
The random ID was added to make the suggest list readable for screen readers, see commit b6b7f3d.
This uses an ID that can get passed in and otherwise uses a default ID. The ID then is added to the input and the list with a prefix. Closes #450, too.
Checklist