fix(Geosuggest): fix input id and label for #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaogarin
commented
Oct 21, 2021
plumdumpling
reviewed
Aug 3, 2023
|
Will look into these today, sorry was away for vacation but happy to continue the work here |
Co-authored-by: Leslie Lawendel <plumdumpling@users.noreply.github.com>
plumdumpling
reviewed
Sep 1, 2023
Co-authored-by: Leslie Lawendel <plumdumpling@users.noreply.github.com>
plumdumpling
approved these changes
Oct 17, 2023
|
Any chance that this gets merged? I would love to have this fix and do an update on our end ;) thanks! if not on #511 then on the next on maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
#490
Right now the label and id input do not work as its explained in the documentation and also how one would probably expect (the label "for" attribute would link to the input "id" :
In the readme section :
However what happens currently is this :
With this PR the label for and input id will match. a test was also included to insure this stays as expected in the future
Note : I do understand this could potentially break people's end to end tests which is actually how I found otu the issue myself trying to upgrade to the latest version, because this was already changed as previously the input id was the props.id directly (which is what I would expect)- This technically could be considered a breaking change, but a breaking change was already then made in #464 so I guess here is not really anything new.
Checklist