Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package and GitHub agnostic option #5

Closed
gentlementlegen opened this issue Apr 4, 2024 · 11 comments · Fixed by #7
Closed

Package and GitHub agnostic option #5

gentlementlegen opened this issue Apr 4, 2024 · 11 comments · Fixed by #7

Comments

@gentlementlegen
Copy link
Member

The package is usable as a GitHub action but does not offer any option to be directly imported in the code of another project.
Having it as a NPM Package would greatly facitate integration within other projects without the hassle of importing submodules, or using Actions.

The package should also offer an option to be GitHub Action agnostic, because its purpose is simply to generate permits.

Tasks to be carried on:

  • package, bundle and type the functions within .d.ts files
  • export the package to NPM
  • make overloads of GitHub agnostic permit generation
@gentlementlegen gentlementlegen self-assigned this Apr 4, 2024
@0x4007
Copy link
Member

0x4007 commented Apr 4, 2024

  1. Be sure to provide a time estimate
  2. What's the motivation? The only places it's used now is in the pay.ubq.fi repo just for development/testing purposes, and this plugin

In the vision I propose about summing payment requests, this means that a permit will only be generated in this plugin, not inside of other plugins. I don't think this task is necessary.

@gentlementlegen
Copy link
Member Author

@pavlovcik This is aimed to help for ubiquibot/conversation-rewards#5 or if eventually we want it to be ran by the kernel itself, related to our discussion

@gentlementlegen gentlementlegen added good first issue Good for newcomers Time: <2 Hours and removed good first issue Good for newcomers labels Apr 4, 2024
@0x4007
Copy link
Member

0x4007 commented Apr 4, 2024

I replied and definitely think this is not a task worth pursing.

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Copy link

ubiquibot bot commented Apr 4, 2024

# Issue was not closed as completed. Skipping.

@0x4007
Copy link
Member

0x4007 commented Apr 4, 2024

If you want to implement this as a temporary solution, i.e. tech debt, then perhaps it makes sense so that we can get back on track with our schedule.

Copy link

ubiquibot bot commented Apr 9, 2024

! No price label has been set. Skipping permit generation.

Copy link

ubiquibot bot commented Apr 9, 2024

+ Evaluating results. Please wait...

@0x4007
Copy link
Member

0x4007 commented Apr 9, 2024

+ Evaluating results. Please wait...

We got rate limited https://github.com/ubiquibot/comment-incentives/actions/runs/8617933701/job/23619113189

Seems like this can be a problem as we pick up on activity in our network.

Copy link

ubiquibot bot commented Apr 9, 2024

[ 23.7 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment415.4
ReviewComment28.3
Conversation Incentives
CommentFormattingRelevanceReward
1. Be sure to provide a time estimate 2. What's the motivation?...
8.7
li:
  count: 2
  score: "2"
  words: 33
0.248.7
I replied and definitely think this is not a task worth pursing....
1.20.291.2
If you want to implement this as a temporary solution, i.e. tech...
30.373
> ```diff > + Evaluating results. Please wait... > ```

We g...

2.5

code:
  count: 1
  score: "1"
  words: 0
0.052.5
I don't have time to look through code, and will instead focus o...
7.9
a:
  count: 1
  score: "1"
  words: 2
0.357.9
Knip: the Sisyphusian task ...
0.40.240.4

[ 142.4 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification122.6
IssueTask150
IssueComment17.4
IssueComment10
ReviewComment341.6
ReviewComment320.8
Conversation Incentives
CommentFormattingRelevanceReward
The package is usable as a GitHub action but does not offer any ...
22.6
li:
  count: 3
  score: "3"
  words: 24
code:
  count: 1
  score: "1"
  words: 2
122.6
@pavlovcik This is aimed to help for https://github.com/ubiquibo...
7.4
a:
  count: 1
  score: "1"
  words: 1
0.377.4
@pavlovcik This is aimed to help for https://github.com/ubiquibo...
-
a:
  count: 1
  score: "0"
  words: 1
0.37-
`NPM_TOKEN` would be needed in the env to properly publish the p...
15.6
code:
  count: 2
  score: "4"
  words: 2
0.4215.6
@pavlovcik yep I agree. This library will simply allow us to mov...
14.8
code:
  count: 1
  score: "2"
  words: 3
0.7814.8
> Knip kung-fu and Jest tests green (tests passing on branch loc...
11.2
code:
  count: 2
  score: "4"
  words: 2
0.611.2
`NPM_TOKEN` would be needed in the env to properly publish the p...
7.8
code:
  count: 2
  score: "2"
  words: 2
0.427.8
@pavlovcik yep I agree. This library will simply allow us to mov...
7.4
code:
  count: 1
  score: "1"
  words: 3
0.787.4
> Knip kung-fu and Jest tests green (tests passing on branch loc...
5.6
code:
  count: 2
  score: "2"
  words: 2
0.65.6

[ 26.7 WXDAI ]

@gitcoindev
Contributions Overview
ViewContributionCountReward
ReviewComment826.7
Conversation Incentives
CommentFormattingRelevanceReward
I noticed Knip is failing in this repo, I will fix this today....
1.30.731.3
I fixed Knip configuration and opened an another pull request, s...
60.756
@gentlementlegen as expected after merging there are a few confl...
3.70.4853.7
I found a few issues and fixed them, it complains about jest typ...
2.50.512.5
Knip kung-fu and Jest tests green (tests passing on branch local...
3.70.533.7
> > Knip kung-fu and Jest tests green (tests passing on branch l...
4.4
code:
  count: 2
  score: "2"
  words: 2
0.624.4
@gentlementlegen I fixed tests, had to add explicit imports and ...
50.675
> Knip: the Sisyphusian task

![myths-legends-greek-greek_myth...

0.10.020.1

@0x4007 0x4007 mentioned this issue Apr 9, 2024
Copy link

ubiquibot bot commented Apr 15, 2024

[ 25.3 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment417
ReviewComment28.3
Conversation Incentives
CommentFormattingRelevanceReward
1. Be sure to provide a time estimate 2. What's the motivation?...
8.7
li:
  count: 2
  score: "2"
  words: 33
0.218.7
I replied and definitely think this is not a task worth pursing....
1.20.221.2
If you want to implement this as a temporary solution, i.e. tech...
30.323
> ```diff > + Evaluating results. Please wait... > ```

We g...

4.1

code:
  count: 1
  score: "1"
  words: 0
0.174.1
I don't have time to look through code, and will instead focus o...
7.9
a:
  count: 1
  score: "1"
  words: 2
0.47.9
Knip: the Sisyphusian task ...
0.40.350.4

[ 142.4 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueSpecification122.6
IssueTask150
IssueComment17.4
IssueComment10
ReviewComment341.6
ReviewComment320.8
Conversation Incentives
CommentFormattingRelevanceReward
The package is usable as a GitHub action but does not offer any ...
22.6
li:
  count: 3
  score: "3"
  words: 24
code:
  count: 1
  score: "1"
  words: 2
122.6
@pavlovcik This is aimed to help for https://github.com/ubiquibo...
7.4
a:
  count: 1
  score: "1"
  words: 1
0.367.4
@pavlovcik This is aimed to help for https://github.com/ubiquibo...
-
a:
  count: 1
  score: "0"
  words: 1
0.36-
`NPM_TOKEN` would be needed in the env to properly publish the p...
15.6
code:
  count: 2
  score: "4"
  words: 2
0.5815.6
@pavlovcik yep I agree. This library will simply allow us to mov...
14.8
code:
  count: 1
  score: "2"
  words: 3
0.8214.8
> Knip kung-fu and Jest tests green (tests passing on branch loc...
11.2
code:
  count: 2
  score: "4"
  words: 2
0.59511.2
`NPM_TOKEN` would be needed in the env to properly publish the p...
7.8
code:
  count: 2
  score: "2"
  words: 2
0.587.8
@pavlovcik yep I agree. This library will simply allow us to mov...
7.4
code:
  count: 1
  score: "1"
  words: 3
0.827.4
> Knip kung-fu and Jest tests green (tests passing on branch loc...
5.6
code:
  count: 2
  score: "2"
  words: 2
0.5955.6

[ 26.7 WXDAI ]

@gitcoindev
Contributions Overview
ViewContributionCountReward
ReviewComment826.7
Conversation Incentives
CommentFormattingRelevanceReward
I noticed Knip is failing in this repo, I will fix this today....
1.30.791.3
I fixed Knip configuration and opened an another pull request, s...
60.8656
@gentlementlegen as expected after merging there are a few confl...
3.70.6653.7
I found a few issues and fixed them, it complains about jest typ...
2.50.532.5
Knip kung-fu and Jest tests green (tests passing on branch local...
3.70.483.7
> > Knip kung-fu and Jest tests green (tests passing on branch l...
4.4
code:
  count: 2
  score: "2"
  words: 2
0.614.4
@gentlementlegen I fixed tests, had to add explicit imports and ...
50.665
> Knip: the Sisyphusian task

![myths-legends-greek-greek_myth...

0.10.070.1

@gitcoindev
Copy link
Contributor

I triggered once more in debug mode, will not spam anymore here -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants