feat: add audit page #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveantor
reviewed
Apr 7, 2023
|
|
||
| <script src="https://cdn.ethers.io/lib/ethers-5.2.umd.min.js" type="application/javascript"></script> | ||
|
|
||
| <script type="module"> |
There was a problem hiding this comment.
you should use typescript + bundler
There was a problem hiding this comment.
Yes, this is more of a concept, if it is fine then we can move to TS and a whole lot of other feature
0x4007
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Its really cool to see working. I went through the source code and determined that it decodes the permits it finds on the GitHub comments (posted by the bot.) It seems like a great approach.
We definitely should work on performance optimization as it takes awhile to run.
|
maybe have the TX as a link and use that space for the issue name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22
This PR adds the "audit page" where a treasurer can match issue payout with an ethereum transaction.
How to test:
If the concept is fine we can add more features like custom css, retries on error, etc...