-
Notifications
You must be signed in to change notification settings - Fork 61
Invalid Property Error Logging #799
Comments
/start |
Tips:
|
Testing was quite tricky but I finally got it. QA passes both for situations when unnecessary properties were defined in the config: (gitcoindev#12 (comment)) and when some required properties are missing: (gitcoindev#12 (comment)) I will open a pull request soon. |
The bot replies directly to invocations with invalid config to make it clear why it's down. A new helper method upsertLastCommentToIssue was introduce to avoid adding multpile comments with the same error message. Resolves: ubiquity#799
As suggested during PR review, getAllIssueComments returns all issue comments using paginated response. Resolves: ubiquity#799
* feat: reply to invalid config The bot replies directly to invocations with invalid config to make it clear why it's down. A new helper method upsertLastCommentToIssue was introduce to avoid adding multpile comments with the same error message. Resolves: #799 * fix: add missing await for upsertLastCommentToIssue Resolves: #799 * chore: uUpdate src/helpers/issue.ts * feat: use getAllIssueComments in upsertLastCommentToIssue As suggested during PR review, getAllIssueComments returns all issue comments using paginated response. Resolves: #799 * feat: upsertLastCommentToIssue use raw format --------- Co-authored-by: 0xCodercrane <108444211+0xcodercrane@users.noreply.github.com>
Task Assignee Reward[ CLAIM 150 WXDAI ]
If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you! |
Task Creator Rewardpavlovcik: [ CLAIM 39.9 WXDAI ] |
So what exactly should the repo config look like as I've pulled a fresh dev branch and the only property that doesn't flag an issue for me at least is incentives... I thought it was my config so I stole rndquu's org config and same thing. evmNetworkId: 100
issueCreatorMultiplier: 1
timeLabels:
- name: "Time: <1 Hour"
- name: "Time: <2 Hours"
- name: "Time: <4 Hours"
- name: "Time: <1 Day"
- name: "Time: <1 Week"
priorityLabels:
- name: "Priority: 1 (Normal)"
- name: "Priority: 2 (Medium)"
- name: "Priority: 3 (High)"
- name: "Priority: 4 (Urgent)"
- name: "Priority: 5 (Emergency)"
defaultLabels:
- "Time: <1 Hour"
- "Priority: 1 (Normal)"
paymentPermitMaxPrice: 1000
commentIncentives: true
maxConcurrentAssigns: 5
promotionComment: ""
assistivePricing: true
registerWalletWithVerification: false
commandSettings:
- name: start
enabled: true
- name: stop
enabled: true
- name: wallet
enabled: true
- name: multiplier
enabled: true
- name: query
enabled: true
- name: autopay
enabled: true
- name: allow
enabled: true
- name: help
enabled: true
- name: payout
enabled: true
- name: ask
enabled: true
disableAnalytics: false
enableAccessControl:
label: true
organization: true
incentives:
comment:
elements:
code: 5
img: 5
h1: 1
li: 0.5
a: 0.5
blockquote: 0
totals:
word: 0.1 |
hi @Keyrxng this is interesting why it does not work for you. I went an extra mile here and I experimented on my fork, which is in repo not org and it seems to work correctly. See here: gitcoindev#14 First I used an initial config, then I enabled a few commands old-style with a hyphen and got an error. Then I corrected the error and config was recognized. Finally I took the exact @rndquu 's config that you pasted and it also works for me. |
I pinged you on your QA comments, appreciate you taking the time |
+1 |
Ok, I'm getting the same error: Checking the root cause of it |
I removed the build folder ( |
|
Also would be great if this specific property error was fixed too.
4b4c8f8
Invalid config according to the logs
Originally posted by @pavlovcik in #793 (comment)
The text was updated successfully, but these errors were encountered: