Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gradle support and CI for android sample project #143

Merged
merged 83 commits into from
Oct 27, 2021

Conversation

dzchen940516
Copy link
Contributor

No description provided.

Dingzhong Chen and others added 30 commits July 19, 2021 15:56
Trithek and others added 25 commits October 26, 2021 16:15
* Added support for IsPublishable C# project config item
…ready existed in the dictionary" exception

Instead of using our GetValueOrAdd extension, use the GetOrAdd that's provided by the ConcurrentDictionary
…hreads

This could lead to crashes when the lists are appended: "Destination array was not long enough. Check destIndex and length, and the array's lower bounds"
…stead of the prebuild of the node that outputs."

This can create issues with executables finishing to link before their
dependencies, especially with postbuild steps like unit-tests.

This reverts commit a184e66.
… for instance)

We now use .TestInput instead of .PreBuildDependencies because a change
in one of the item in that list doesn't trigger a build of the node...
@dzchen940516
Copy link
Contributor Author

Just resolved all the merge conflicts from the dev branch. Let me know if there're any issues. :)

@belkiss belkiss merged commit 1bce190 into ubisoft:dev Oct 27, 2021
@belkiss
Copy link
Contributor

belkiss commented Oct 27, 2021

Merged, thanks!

mundak pushed a commit to mundak/Sharpmake that referenced this pull request Nov 11, 2021
belkiss pushed a commit to belkiss/Sharpmake that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants