Added support for IsPublishable C# project config item #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belkiss
suggested changes
Sep 15, 2021
| @@ -546,6 +546,16 @@ public enum SonarQubeExclude | |||
| Disabled, | |||
| Enabled | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Controls whether the project is published when running a publish command | |||
There was a problem hiding this comment.
Seems this property is only applicable for dotnet sdk projects, could you indicate that in the comments please?
| @@ -3426,6 +3426,13 @@ private Options.ExplicitOptions GenerateOptions(CSharpProject project, Project.C | |||
| Options.Option(Options.CSharp.ProduceReferenceAssembly.Disabled, () => { options["ProduceReferenceAssembly"] = RemoveLineTag; }) | |||
| ); | |||
|
|
|||
|
|
|||
| SelectOption | |||
| ( | |||
There was a problem hiding this comment.
Fix indentation (we use spaces)
There was a problem hiding this comment.
Ah, some slipped through. Fixed
Also added comment to indicate that IsPublishable only affects dotnet projects
|
Merged, thanks! |
dzchen940516
pushed a commit
to dzchen940516/Sharpmake
that referenced
this pull request
Oct 26, 2021
* Added support for IsPublishable C# project config item
belkiss
pushed a commit
to belkiss/Sharpmake
that referenced
this pull request
Nov 15, 2021
* Added support for IsPublishable C# project config item
SharpmakeRobot
pushed a commit
that referenced
this pull request
Mar 22, 2023
Make Samples compile to ease code navigation Closes #144 See merge request Sharpmake/sharpmake!364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.