Skip to content
This repository has been archived by the owner on Mar 8, 2019. It is now read-only.

Sections in header instead of menu #159

Merged
merged 4 commits into from Mar 7, 2019
Merged

Sections in header instead of menu #159

merged 4 commits into from Mar 7, 2019

Conversation

krille-chan
Copy link
Contributor

No description provided.

@krille-chan
Copy link
Contributor Author

There are two proposals. This are the normal "Sections" from the Ubuntu Components:
ppzflschklvxmtssmxewvqwr
The problem with this is, that the user may think that he can swipe to the left or the right to switch between these sections but he will just switch the month, the week and so on...

krwwzfppfxmtpuasjazkcoje
Does not have this problem but it may not look so nice...

@hummlbach
Copy link
Collaborator

I didn't know that the normal/usual way to change the tabs is by swiping left or right :) at least in podbird and the address-book-app thats not the case. Thanks for creating that!

@krille-chan
Copy link
Contributor Author

I didn't know that the normal/usual way to change the tabs is by swiping left or right :) at least in podbird and the address-book-app thats not the case. Thanks for creating that!

Ooh, I see you are right 😅 well maybe I was wrong about this assumption.

@UniversalSuperBox
Copy link
Member

It is how you switch tabs in clock-app though. If we think this is something we want to do, we would need to implement it across all the core apps with tabbed UI.

@bhdouglass
Copy link
Member

@hummlbach is this something we want to merge in? Might want @cibersheep to check it out.

@cibersheep
Copy link
Contributor

I vote for the first option (with the tabs). The only app that changes tabs with a swipe is the clock, which is not the default behaviour of tabs :)

I love that you take away the left menu hurray!

imatge

@hummlbach
Copy link
Collaborator

@hummlbach is this something we want to merge in?

Yes, we definitely want to have that! I've already discussed with @ChristianPauly 3 weeks ago. As @cibersheep I would opt for the first. We were also discussing about the order of the tabs. Here i would like to reverse the order. @ChristianPauly either you do it, or I'll do that next week and afterwards lets merge it.
One additional thing; actually there are more severe glitches with the calendar on a big screen, but nonetheless: any idea how to make that look better? (Or is it okay with the tabs left aligned, looks a bit strange to me....)
calendarsections

@krille-chan
Copy link
Contributor Author

I would place the tabs in the center. That makes the best look on large screens or on the desktop. Or maybe even better we place them in the center and put them in the top header between the "January 2018" and the three buttons on the right, when the application window is large enaugh for it.

@krille-chan
Copy link
Contributor Author

What do you think about this solution? When the window is large enaugh, the header will have only one row and the sections will be centered:
https://chat.regionetz.net/_matrix/media/v1/download/chat.regionetz.net/vhdcIAxzOwjUpqcciVvfoyGx

And it is changing automatically from the two states as you can see here:
https://janian.de/index.php/s/CpfDpZe2nLCCnf3

Copy link
Collaborator

@hummlbach hummlbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my suggestion, on how to change the tab order.
change_tab_order.patch.txt

@cibersheep
Copy link
Contributor

cibersheep commented Mar 3, 2019

@ChristianPauly Looks great to me

@hummlbach hummlbach merged commit 55b4423 into ubports:master Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants