plugins: fastboot: add commands for interacting with logical partitions #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the following new action:
- actions:
- fastboot:create_logical_partition:
partition: "partition_name"
size: 3221225472
- fastboot:delete_logical_partition:
partition: "partition_name"
- fastboot:resize_logical_partition:
partition: "partition_name"
size: 3221225472
These actions are required for certain devices with
dynamic partitions, like the Fairphone 4.
Change-Id: I02e0dc1dcfa3674bbdb2525e4abdff7dfbe868b4
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
|
This is required for the Fairphone 4 installer bringup. |
Flohack74
previously approved these changes
Jul 6, 2022
mariogrip
previously approved these changes
Jul 6, 2022
|
@amartinz is this failing in CI on purpose? |
Yes, see |
|
@NeoTheThird Any chance you can review this some time soon? We need this change to get into the installer for deploying Ubuntu Touch on e.g. Fairphone 4. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
+ Coverage 77.24% 77.59% +0.34%
==========================================
Files 29 29
Lines 967 982 +15
==========================================
+ Hits 747 762 +15
Misses 220 220
Continue to review full report at Codecov.
|
mariogrip
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the following new action:
These actions are required for certain devices with
dynamic partitions, like the Fairphone 4.
Requirements
promise-android-toolsneeds support for these actions:Then we need a new release of it and dependencies need to be updated.