-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #710
Merged
Merged
Refactor #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the initial steps of our long expected refactoring. - Include the command-line interface in the normal app (even though it does not do anything yet) - Tame the crossfiring commands, fixes #187 and possibly many other issues - Fixes stupid bug where we tried to execute [Object] - More intuitive loading bars - Improve logging by, like, a lot - Remove a lot of unused code - Improvements of code quality in some areas - Move stuff around - More useful event handling - Finish adb-support snapd interface implementation, fixes #258 - Implement ubports-api-node-module - Use new (a year old, holy shit time is flying!) API server, fixes #692 - Shut the child process up, fixes #216 - Fix macos paths
…dling and fixed a weird issue that caused the particle animation to only show up in debug mode
mariogrip
approved these changes
Mar 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Good work!
Thank you! |
This was referenced Mar 18, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the initial steps of our long expected refactoring! Testing is done on the interim release. I definitely want at least one entry in every row and one in every column before merging, but maybe we can already get started on code reviews :)
New features
Bugfixes
issues
fastboot boot
issue on Meizu Pro 5General improvements related to unreported or distributed issues