This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Add multi monitor and workspace support #164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariogrip
force-pushed
the
xenial_-_edge_-_multiscreen
branch
from
d8754ae
to
97709db
Compare
mariogrip
force-pushed
the
xenial_-_edge_-_multiscreen
branch
from
97709db
to
89863e0
Compare
This makes sure to set surface to null when the surface is no longer live, this was done in qml before, but has been removed as the window manager should handle this, this reflect that change in the mocks.
This was done in stage when application requested forcus, but this is no longer done as it makes no sense to close spread on app start/focus
mariogrip
force-pushed
the
xenial_-_edge_-_multiscreen
branch
from
89863e0
to
77038f1
Compare
|
Ok tests are fixed now. Had two i had to disable for now, but those are not deal breakers for now (as these are for menybar). |
|
pr-merge is expected to fail, as it does not have qtmirserver-dev. |
|
Branch is failing too. |
mariogrip
force-pushed
the
xenial_-_edge_-_multiscreen
branch
3 times, most recently
from
b5938e7
to
2044c2e
Compare
This moves surface manager to local member of WorkspaceManager insted of accessing the static object, this makes sure we catch the destroy signal in same thread as we run in.
This makes sure we unset VM objects before destruction, this makes sure we do not access a alredy destroyed object.
mariogrip
force-pushed
the
xenial_-_edge_-_multiscreen
branch
from
2044c2e
to
3e71837
Compare
This was referenced Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds multi monitor and workspace support. Workspace is disabled by default, but can be forced on.
This is massive!
Needs:
ubports/qtmir#25
ubports/unity-api#15