Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Don't use peeking animation when drawer is open #362

Merged
merged 1 commit into from Jan 28, 2021
Merged

Don't use peeking animation when drawer is open #362

merged 1 commit into from Jan 28, 2021

Conversation

dobey
Copy link
Member

@dobey dobey commented Jan 27, 2021

Fixes #361

UniversalSuperBox
UniversalSuperBox suggested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure on armhf seems to be a race condition, since it passes on the other architectures:

FAIL!  : qmltestrunner::Launcher::test_peekNotRunWhenDrawerOpen() Compared values are not the same
   Actual   (): false
   Expected (): true
   Loc: [/build/unity8-8.20+ubports+0~20210128091109.2~1.gbp5910f1/tests/qmltests/Launcher/tst_Launcher.qml(1641)]

@dobey
Copy link
Member Author

dobey commented Jan 28, 2021

I've changed the test to use tryCompare instead here, and the tests now pass. I also fixed the grammatical faux pas.

@UniversalSuperBox UniversalSuperBox merged commit 6119aaf into xenial Jan 28, 2021
@dobey dobey deleted the xenial_-_fix-peeking branch January 28, 2021 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Flohack74 Flohack74 Flohack74 approved these changes

@UniversalSuperBox UniversalSuperBox UniversalSuperBox approved these changes

@peat-psuwit peat-psuwit Awaiting requested review from peat-psuwit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launcher is invisible sometimes
3 participants
@dobey @Flohack74 @UniversalSuperBox