-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy entire source, even if source-subdir is specified. #344
Copy entire source, even if source-subdir is specified. #344
Conversation
92a5e00
to
45667dc
Compare
tmpdir = tempfile.TemporaryDirectory() | ||
self.addCleanup(tmpdir.cleanup) | ||
plugin.builddir = tmpdir.name | ||
self.assertEqual(os.path.join(plugin.buildbasedir, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there will be less indentation eyeball matching if done like
self.assertEqual(
os.path.join(plugin.buildbasedir, options.source_subdir),
plugin.builddir)
I am 👍 but would really like those cosmetics fixed as I have difficulties aligning if it is too deep 😉 |
Easy changes! I'll keep that in mind for the future-- I've always tried to stretch the line as far as it'll go but you're right, it has its limits. Thanks for the review 😃 . |
Currently, if source-subdir is specified, Snapcraft copies ONLY that subdir (and excludes the rest of the source) and attempts to build from it. This only works for some projects, not all. A better solution is to copy the entire source and simply build from WITHIN the subdir. That is the change introduced here. LP: #1549676 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
45667dc
to
6beb6fe
Compare
Grr... over quota or some such thing... |
retest this please |
1 similar comment
retest this please |
Tested locally-- examples pass. |
…l_copy_all Copy entire source, even if source-subdir is specified.
Exceptions thrown from rdma processing thread running in the background were not logged properly. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
…bdir_still_copy_all Copy entire source, even if source-subdir is specified.
Currently, if source-subdir is specified, Snapcraft copies ONLY that subdir (and excludes the rest of the source) and attempts to build from it. This only works for some projects, not all. A better solution is to copy the entire source and simply build from WITHIN the subdir. This PR fixes LP: #1549676 by introducing exactly that change. It does so without changing the plugin API or semantics.