Move the 'flutter build' commands from CI into MSBuild #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since now we will not have only the slide show but the whole OOBE application.
It can be referring to the slide show (aka splash) or the OOBE
Now let by MSBuild
|
This run shows that we won't stop bundling the Flutter artifacts into the x64 part of the bundle.
|
EduardGomezEscandell
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI workflow is meant to provide the resources and execute the build system. Having it to know which Flutter project to builder (it could be either the current slide show or the new OOBE coming soon) and build it before invoking the actual build system that will output the appx bundle is a bad smell.
Instead we can let the build system (MSBuild) to handle building whatever dependencies the appx might have, only requiring the CI workflow to know that it must provide the Flutter command and that’s it.
This PR applies some renaming to turn it more subproject-agnostic in terms of whether we build the slide show or the OOBE application, as well as removing the build commands from CI workflow YAML files, leaving that to the actual build system (MSBuild) to handle.