Adapting nss integration tests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisonbarbosa
force-pushed
the
adapting-nss-integration-tests
branch
from
4c5c7fd
to
c68bd18
Compare
Fixed the linking process for the nss c library and the cache options to be passed to the aad-auth executable. Co-authored by: Gabriel Nagy <gabriel.nagy@canonical.com>
Also planning on adding checks for the type of error that was returned as well.
GabrielNagy
reviewed
Sep 7, 2022
didrocks
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Some small comments, but overall, this is great!
Please double check again that all previous tests cases are still covered with the refactoring, I saw at least that those one are not: try to list by name or uid in group and passwd without access to shadow.
Also, we discussed on MM about listing the group. I doubt this is a buffer issue, we can check together.
Added test cases to handle calls to Getent with "" keys. Co-authored by: Didier Roche <didrocks@ubuntu.com>
Now the call to outNssCommandForLib actually returns all the entries, as requested. Also addressed a few other comments in the PR. Co-authored-by: Didier Roche <didrocks@ubuntu.com>
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
Now it's possible to pass an explicit empty key ("") to the aad-auth cli
and have it perform the same operation as getent would -> query the
database for the "" key, rather than treating it as a nil value.
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
Co-authored-by: Didier Roche <didrocks@ubuntu.com>
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 75.98% 82.76% +6.78%
==========================================
Files 39 34 -5
Lines 2436 2234 -202
==========================================
- Hits 1851 1849 -2
+ Misses 524 324 -200
Partials 61 61
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didrocks
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting the tests to fit in the new NSS C library.