Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Adapting nss integration tests #59

Merged
merged 21 commits into from Sep 8, 2022
Merged

Adapting nss integration tests #59

merged 21 commits into from Sep 8, 2022

Commits on Sep 6, 2022

  1. First try on the new nss integration tests

    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2cf977f View commit details
    Browse the repository at this point in the history

  2. Fixing TestMain function and a nullptr in TestNssGetent

    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c68bd18 View commit details
    Browse the repository at this point in the history

  3. Fixing the building process required for the integration tests. 

    Fixed the linking process for the nss c library and the cache options to
be passed to the aad-auth executable.

Co-authored by: Gabriel Nagy <gabriel.nagy@canonical.com>
    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    02f2568 View commit details
    Browse the repository at this point in the history

  4. Updating some tests cases to require errors. 

    Also planning on adding checks for the type of error that was returned
as well.
    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2455f9a View commit details
    Browse the repository at this point in the history

  5. Fixing linter issues with duplicate code.

    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6734c37 View commit details
    Browse the repository at this point in the history

  6. Adding golden files for the integration tests

    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f96cfb2 View commit details
    Browse the repository at this point in the history

  7. Removing unused files

    @denisonbarbosa
    denisonbarbosa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    84347a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Refactoring helper_test.go to improve clarity and readability.

    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5f377a8 View commit details
    Browse the repository at this point in the history

  2. Adapting QA build rules to build the new NSS C Lib and NSS Cli exec.

    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fd9edcb View commit details
    Browse the repository at this point in the history

  3. Addressing PR comments

    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c1b8a5c View commit details
    Browse the repository at this point in the history

  4. Adding test cases to TestGetEnt 

    Added test cases to handle calls to Getent with "" keys.

Co-authored by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    63175c6 View commit details
    Browse the repository at this point in the history

  5. Fixing bug in the integration tests and addressing a few other comments. 

    Now the call to outNssCommandForLib actually returns all the entries, as
requested.
Also addressed a few other comments in the PR.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa @didrocks
    denisonbarbosa and didrocks committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f505bd4 View commit details
    Browse the repository at this point in the history

  6. Adding ifdef guards to db_override_test.c 

    Co-authored-by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa @didrocks
    denisonbarbosa and didrocks committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    3141b80 View commit details
    Browse the repository at this point in the history

  7. Changing NSS C lib and NSS CLI to work a bit more like getent 

    Now it's possible to pass an explicit empty key ("") to the aad-auth cli
and have it perform the same operation as getent would -> query the
database for the "" key, rather than treating it as a nil value.

Co-authored-by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa @didrocks
    denisonbarbosa and didrocks committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6216842 View commit details
    Browse the repository at this point in the history

  8. Adding golden files for previously added integration test cases

    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fbaa045 View commit details
    Browse the repository at this point in the history

  9. Now the NSS C lib properly prints the debug info if AAD_NSS_DEBUG is set 

    to stderr
    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6986c50 View commit details
    Browse the repository at this point in the history

  10. Renaming tests and updating golden files

    @denisonbarbosa
    denisonbarbosa committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d592d5a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Making the NSS CLI be able to query dbs for "" and addressing a few 

    other comments
    @denisonbarbosa
    denisonbarbosa committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    325ff08 View commit details
    Browse the repository at this point in the history

  2. Moving log call to GetEntryByKey and adding nosec notation

    @denisonbarbosa
    denisonbarbosa committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    5126f02 View commit details
    Browse the repository at this point in the history

  3. Fixing the integration tests 

    Co-authored-by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa @didrocks
    denisonbarbosa and didrocks committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b511e08 View commit details
    Browse the repository at this point in the history

  4. Renaming test cases and updating golden files 

    Co-authored-by: Didier Roche <didrocks@ubuntu.com>
    @denisonbarbosa @didrocks
    denisonbarbosa and didrocks committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    114743a View commit details
    Browse the repository at this point in the history