-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlocalized command line options #656
Comments
See related issue: ubuntu/adsys#656
This sure does look like a problem. But the fix should be as simple as moving a line. I'll open a PR for it real quick. |
Agreed, it's just moving the InitDomain to the We use this pattern in multiple repos (and even multiple places in some repose), so we should also consider where else this bug may exist. |
See related issue: ubuntu/adsys#656
Is it still an issue in ADSys? |
Haven't manually checked. From reading the code, it would appear it still is an issue. |
Description
i18n
is initialized too late.In
adsysd/main.go
and possibly all other main functions:Nothing in the constructors is actually localized. So for instance --help will always show up in english.
Reproduction
I haven't tested it because I don't know how to build the project, I got this from static analysis when copying this project structure.
The text was updated successfully, but these errors were encountered: