Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide kTogglableActiveResizeFactor out of the public API #494

Merged
merged 1 commit into from Jan 11, 2023
Merged

Hide kTogglableActiveResizeFactor out of the public API #494

merged 1 commit into from Jan 11, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 11, 2023

@Jupi007 is this ok to hide? do we need it in the public constants.dart? it's only used in togglable.dart.

Ref: #489

@jpnurmi jpnurmi requested a review from Jupi007 January 11, 2023 16:44
Jupi007
Jupi007 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is completely okay to move this 👍
I surely put it here because I was access to it from both checkbox and radio fiels in early versions. Anyway, it's place is here you moved it 🙂

@jpnurmi jpnurmi merged commit a82226c into ubuntu:main Jan 11, 2023
@jpnurmi jpnurmi deleted the togglable-resize-factor branch January 11, 2023 16:49
This was referenced Jan 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007