Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YaruToggleButton subclasses stateful #661

Merged
merged 1 commit into from Mar 6, 2023
Merged

Make YaruToggleButton subclasses stateful #661

merged 1 commit into from Mar 6, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 6, 2023 •
edited

This is a noisy preparation step for #659 to make it possible for YaruToggleButton subclasses to create and dispose an internal MaterialStatesController.

@jpnurmi
Make YaruToggleButton subclasses stateful
ffe148c 
This is a noisy preparation step for #659 to make it possible for them
to create and dispose an internal MaterialStatesController.

Ref: #659
@jpnurmi jpnurmi requested a review from Jupi007 March 6, 2023 09:51
Jupi007
Jupi007 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@jpnurmi jpnurmi merged commit d9ac8a4 into ubuntu:main Mar 6, 2023
@jpnurmi jpnurmi deleted the toggle-button-stateful branch March 6, 2023 10:06
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007