Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to flutter_lints 2.0 #698

Merged
merged 2 commits into from May 5, 2023
Merged

Conversation

pablojimpas
Copy link
Contributor

This PR upgrades the dependency of flutter_lints to its current major version.

The only breaking change was that it increased Dart SDK's constraints to >=2.17.0, but this package already has that requirement since 7e3bde7.

I've also removed two rules that were manually enabled, since the new version of lints (which flutter_lints depends on) already enables them. New linter warnings appear after upgrading, and I've fixed some of those with dart fix --apply and others manually.

I did the same for the example project.

@Feichtmeier Feichtmeier requested a review from jpnurmi May 4, 2023 14:42
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit 68123e3 into ubuntu:main May 5, 2023
5 checks passed
@pablojimpas pablojimpas deleted the flutter_lints_2.0 branch May 5, 2023 10:27
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants