New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change sidebar color, improve YMD theme #750
Conversation
8ffb226
to
3b8117d
Compare
those variants are not inherited by some enum or so because they are too complex for but they are possible by setting the background colors of YaruWindowTitleBars and by wrapping the YMD in a YMD with copy with and changing the defaults |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, LGFM 👍
@jpnurmi any veto? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
p.s. navi-rail too?
yeah I should, right? |
IMO it is not a good idea. |
A separate PR is fine, of course, if you decide to apply similar changes. :) |
okay then I apply those changes to YaruNavigationPageThemeData in a second PR |
This brightens up the sidebar for the dark theme a bit and darkens up the sidebar for the light theme a bit. This improves the visual focus on the content on the right (or left)
Plus this also adapts our looks to libadwaita
Possible variants:
Default:
light:
default: