Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change sidebar color, improve YMD theme #750

Merged
merged 2 commits into from Aug 7, 2023
Merged

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Aug 7, 2023

This brightens up the sidebar for the dark theme a bit and darkens up the sidebar for the light theme a bit. This improves the visual focus on the content on the right (or left)
Plus this also adapts our looks to libadwaita

Possible variants:

grafik

grafik

Default:

grafik

light:

grafik

default:
grafik

@Feichtmeier
Copy link
Member Author

those variants are not inherited by some enum or so because they are too complex for
appbar | appbar
list | detailpage
combos

but they are possible by setting the background colors of YaruWindowTitleBars and by wrapping the YMD in a YMD with copy with and changing the defaults

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, LGFM 👍

@Feichtmeier
Copy link
Member Author

@jpnurmi any veto? 😄

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

p.s. navi-rail too?

@Feichtmeier
Copy link
Member Author

LGTM 👍

p.s. navi-rail too?

yeah I should, right?
in this PR or another?
Navirail in material defaults to colorscheme.surface
I wonder if we could rather let yaru navi rail use the material theme? because it is so close to it

@Jupi007
Copy link
Member

Jupi007 commented Aug 7, 2023

I wonder if we could rather let yaru navi rail use the material theme? because it is so close to it

IMO it is not a good idea.

@jpnurmi
Copy link
Member

jpnurmi commented Aug 7, 2023

A separate PR is fine, of course, if you decide to apply similar changes. :)

@Feichtmeier
Copy link
Member Author

I wonder if we could rather let yaru navi rail use the material theme? because it is so close to it

IMO it is not a good idea.

okay then I apply those changes to YaruNavigationPageThemeData in a second PR

@Feichtmeier Feichtmeier merged commit 33fb4c4 into main Aug 7, 2023
7 checks passed
@Feichtmeier Feichtmeier deleted the sidebar_color branch August 7, 2023 16:27
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Feichtmeier added a commit that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants