Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example with the new paned style #778

Merged
merged 1 commit into from Sep 19, 2023
Merged

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Sep 19, 2023

grafik

@Feichtmeier Feichtmeier enabled auto-merge (squash) September 19, 2023 20:26
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Feichtmeier Feichtmeier merged commit 8f9aa7a into main Sep 19, 2023
9 checks passed
@Feichtmeier
Copy link
Member Author

CC @d-loose @anasereijo eventually something to consider for the software app :) the new gtk4 apps look like this

@Feichtmeier Feichtmeier deleted the examplestyle branch September 19, 2023 20:29
@github-actions github-actions bot mentioned this pull request Sep 19, 2023
@elioqoshi
Copy link
Contributor

@Feichtmeier Just to be sure, new paned style refers to the sidebar menu active item, right?

@Feichtmeier
Copy link
Member Author

@elioqoshi
the sidebar now has a stronger contrast against the main part of the window
the default is still with the headerbar having the default background color, but when someone prefers to use the full paned look it can be done very easily by removing the background color and border of headerbars
this is what I meant with "paned" style :) GTK4 apps in with gnome 45 also use this style of "invisible" headerbars and the "full pane" style if it is a "master/detail" application like for example gnome control center (settings)

in this pull request here it is only changed in the example app of yaru widgets
the default still has a grey headerbar with a border, I think this is a sane default

sorry for the long answer, needing a coffee ☕

@Feichtmeier
Copy link
Member Author

@elioqoshi for a better explanation I found the old PR that makes those styles possible, maybe this helps:

#750

@elioqoshi
Copy link
Contributor

Ah that makes sense, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants