fix(YaruTabBar): make TabController nullable, add onTap #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feichtmeier
force-pushed
the
fix_tab
branch
from
4f1e513
to
e87d5cb
Compare
Feichtmeier
changed the title
|
Just looking at the picture, are the tabs more round here than in gtk4? Oo |
Well, yes it looks more round 🧐 |
"If [TabController] is not provided, then the value of [DefaultTabController.of] will be used."
Feichtmeier
force-pushed
the
fix_tab
branch
from
e87d5cb
to
15aea30
Compare
|
ok @Jupi007 changed to the button radius now: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"If [TabController] is not provided, then the value of [DefaultTabController.of] will be used."
Need to check this first if this worksWorks, sorry, should have tested on musicpod/real app first :)
Also added onTap, as this is part of material tabbar api