Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LP#1989844 "Quick settings changes spacing when toggling Dark Mode" #3734

Closed
github-actions bot opened this issue Sep 16, 2022 · 1 comment · Fixed by #3829
Closed

LP#1989844 "Quick settings changes spacing when toggling Dark Mode" #3734

github-actions bot opened this issue Sep 16, 2022 · 1 comment · Fixed by #3829
Assignees
@Jupi007
Labels
Launchpad

Comments

@github-actions
Copy link
Contributor

Reported first on Launchpad at https://bugs.launchpad.net/ubuntu/+source/yaru-theme/+bug/1989844
@vanvugt
Copy link
Contributor

vanvugt commented Feb 27, 2023 •
edited

This looks like the cause:

yaru/gnome-shell/src/gnome-shell-sass/widgets/_slider.scss

Line 24 in a088dbc

height: if($variant == 'light', $slider_size + 2px, $slider_size); // Yaru change: increase height in light theme due to border

@Jupi007 Jupi007 self-assigned this Feb 27, 2023
Jupi007 added a commit that referenced this issue Feb 28, 2023
@Jupi007
LP#1989844 "Quick settings changes spacing when toggling Dark Mode"
f9765c8 
Fixes #3734
@Jupi007 Jupi007 mentioned this issue Feb 28, 2023
Merged
Jupi007 added a commit that referenced this issue Feb 28, 2023
@Jupi007
LP#1989844 "Quick settings changes spacing when toggling Dark Mode" (#…
9b2662a 
…3829)

Fixes #3734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jupi007 Jupi007

Labels
Launchpad
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LP#1989844 "Quick settings changes spacing when toggling Dark Mode" ubuntu/yaru
2 participants
@vanvugt @Jupi007