Release Yaru 19.04 as third variant "Yaru-Ambiance" #1532
Conversation
- create an ambiance folder, copy of the dark one - modify ambiance build script to generate a third variant named Yaru-ambiance - add _headerbar.scss stylesheet from lighter-headerbar-v8:_tweaks.scss - append headerbar stylesheet to Ambiance gtk.scss
Nautilus floating-bar background is transparent, so the label is hard to see if there's some text behind it. Fixing it setting the background to solid, using $bg_color value Also fix text formatting, removing empty spaces.
Firefox was using a unfocused tabs label color for light headerbar. Fixing it re-appling the apps specific code from lighter-headerbar-v8 branch.
Currently tweaks is a light variant of headerbar sass, so it is useless to include both. Keeping headerbar only now.
- add $ambiance variable, that default to null - set Firefox menubar style only if $ambiance is true
- adaptive transparency stopped to work with gnome shell 3.32 - a permanently opaque dock looks quiet heavy in "window not maximized" situations - adding a soft transparency lowers the heavyness of the dock/panel combination a bit
The text-button.toggle.checked did not have the same background color as the other button in the headerbar. Moreover, removed unnecessary double definition of *.toggle widgets
in bothj menu/context-menu and in menubar use fg_color in place of a too strong selection color
This variant is equal to yaru-dark, but it the name yaru-ambiance-dark is neede for apps configured to prefer dark.
|
Some stuff I've noticed:
|
some entries where missing from 3.0 folder and in gresource for the dark variant of ambiance (which is equal to yaru-dark)
|
Could you please drop those additional box-shadows and just set 1 color for the buttons and then use the button mixins? |
Ok |
There is |
|
|
this is Image viewer, right? The app is not taking the right varian here. Applying the dark one manually it works fine |
- lighten up the headerbar like in #1532 - import changes from master that were made in the meantime to titlebutton fix, app notifications and gtk 3.28 switches - remove double imports and double definitions
|
I think the reason for the dark variant not working for videos and eye of gnome and so on... media apps... is that it searches for "gtk-dark.css" but there is none. Instead there is "gtk-ambiance-dark.css" |
|
this branch started with gtk-dark only and didn't work, this is why I added later gtk-ambiance-dark, which is still not working of course. Also, the gtk-dark.css is still in. The goal would be to release only ambiance and keep using only gtk-dark for both themes |
|
@clobrano maybe it's something with that gresource file names |
- lighten up the headerbar like in #1532 - import changes from master that were made in the meantime to titlebutton fix, app notifications and gtk 3.28 switches - remove double imports and double definitions
- revert aubergine to perma, like in master - use the same border-color as in "yaru_headerbar" mixin
In order to keep the right color combination for dark variant let's use the original tweaks sass file in place of headerbar for the ambiance dark variant
…biance Dark variant uses a dark backdrop widget border in headerbar. Use the same in Ambiance. This also adjust the look and feel of entries linked to buttons (see Image viewer). Not perfect, to be reviewed eventually.
- lighten up the headerbar like in #1532 - import changes from master that were made in the meantime to titlebutton fix, app notifications and gtk 3.28 switches - remove double imports and double definitions
After the change of the light variant, in order to ease the transition out, release the Yaru 19.04 (sometimes called "mixed" theme) as third variant.
closes #1494