Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify gnome-shell-theme.gresource #2945

Closed
wants to merge 15 commits into from
Closed

modify gnome-shell-theme.gresource #2945

wants to merge 15 commits into from

Conversation

Muqtxdir
Copy link
Member

@Muqtxdir Muqtxdir commented Jul 4, 2021 •
edited

Hi,

This should be okayed to merge only if the GNOME Shell is patched as discussed here

patches that need to be applied on GNOME Shell for fully functional global dark-theme:

TO-DO:

  • Make Yaru as default shell-theme
  • Add separate dark and light directories
  • Remove alias for gnome-shell.css in gnome-shell-theme.gresource.xml
  • Update sessions to reflect the changes
  • Enable gnome-shell-gresource option as default
    Symlink inverted-themes mix-themes option.
  • Reflect changes for debian/

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Jul 5, 2021 •
edited

with the last commit I enabled gnome-shell-gresource by default, @Jupi007 and @LinuxLlama (since you both are on GNOME 40) could you tryout this branch and share whether GNOME Tweaks lists both Yaru and Yaru-dark under Shell theme.

Note: Please remove any-trace of Yaru before trying out this branch to avoid any conflicts

@LinuxLlama
Copy link
Contributor

It does! The default shell theme is also light now

Screenshot from 2021-07-05 08-04-12

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Jul 5, 2021

It does!

That was quick @LinuxLlama ! and thanks

The default shell theme is also light now

Great, but do note this is not yet finalized and is one of the attempts to counter this issue

clobrano
clobrano requested changes Jul 9, 2021
View reviewed changes
gnome-shell/src/meson.build
@@ -96,6 +106,10 @@ foreach variant: variants
if is_variant
subdir(variant)
endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this two if blocks (between 106 and 112) are not necessary anymore. is_variant is true if variant != light right? So:

  • if is_variant is true, then variant == 'light' and the subdir command is equal to subdir('light')
  • if is_variant is false, then variant != 'light', but subdir command is still equal to subdir('light)

I believe this was necessary when the variantes were three (default, light and dark).

gtk/src/inverted/install-inverted.sh Outdated Show resolved Hide resolved
Muqtxdir and others added 2 commits July 9, 2021 21:43
@Muqtxdir
rename inverted to mix and update gnome-shell-theme.gresource.xml
87ad144
Update mix symlinks
218fc8e 
reason:
- do not present yaru-mix themes under GNOME-tweaks to avoid confusion.

action:
- remove gtk-3.0 symlinks under yaru-mix
@Muqtxdir Muqtxdir changed the title wip: modify gnome-shell-theme.gresource modify gnome-shell-theme.gresource Jul 28, 2021
@Muqtxdir Muqtxdir marked this pull request as ready for review July 28, 2021 16:53
@Muqtxdir
Copy link
Member Author

relevant LP-bug issue: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1943857

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 17, 2022

I'm closing this, as the idea is already part of #3416.

@3v1n0 3v1n0 closed this Mar 17, 2022
@Jupi007 Jupi007 deleted the modify-gnome-shell-gresource branch August 12, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano clobrano requested changes

Assignees
No one assigned
Labels
Area: GNOME-shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Muqtxdir @LinuxLlama @3v1n0 @clobrano @vitalkanev @Jupi007