New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify gnome-shell-theme.gresource #2945
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
53eb8a6
add default and dark directories
Muqtxdir 89330a8
modify meson.build and add install-themes-for-switching
Muqtxdir a2f7ef5
change alias in gnome-shell-theme.gresource.xml
Muqtxdir 5c50127
update yaru-theme-gnome-shell.install
Muqtxdir 56ec0a3
modify sessions/modes.json.in
Muqtxdir 1617748
enable gnome-shell-gresource in meson_options.txt
Muqtxdir fdd5321
add inverted option in meson and symlink inverted-themes
Muqtxdir 358a5aa
regression: rename project-name to Yaru
Muqtxdir 87ad144
rename inverted to mix and update gnome-shell-theme.gresource.xml
Muqtxdir 218fc8e
Update mix symlinks
988493a
sync with master-branch
Muqtxdir 2d3febe
fix gnome-shell-theme.gresource.xml and turn on gresource as true
Muqtxdir ca1ccdb
removed mix-parts
Muqtxdir 0b146e5
Merge branch 'master' into modify-gnome-shell-gresource
Muqtxdir 7d82af7
update debian files
Muqtxdir File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
usr/share/gnome-shell/ | ||
usr/share/themes/Yaru/gnome-shell | ||
usr/share/themes/Yaru-light/gnome-shell/ | ||
usr/share/themes/Yaru/gnome-shell/ | ||
usr/share/themes/Yaru-dark/gnome-shell/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# This is an hack we need to remove once meson fixes this issue: | ||
# https://github.com/mesonbuild/meson/issues/2320 | ||
|
||
custom_target('style-css-@0@'.format(variant), | ||
input: style_css, | ||
output: output_styles, | ||
command: [ | ||
gnomeshell_copy_and_rename, | ||
'--input', '@INPUT@', | ||
'--output', '@OUTPUT@', | ||
], | ||
install: true, | ||
install_dir: install_dir, | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env bash | ||
# -*- coding: UTF-8 -*- | ||
|
||
project_name="$1" | ||
project_lname="$2" | ||
gnomeshell_theme_dir="${MESON_INSTALL_DESTDIR_PREFIX}/$3" | ||
variant_suffix="$4" | ||
variant_target="${gnomeshell_theme_dir}/${project_name}${variant_suffix}/gnome-shell.css" | ||
variant_symlink="${gnomeshell_theme_dir}/${project_lname}${variant_suffix}.css" | ||
|
||
cp $variant_target $variant_symlink |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"parentMode": "user", | ||
"stylesheetName": "@ThemeName@/gnome-shell.css", | ||
"stylesheetName": "gnome-shell.css", | ||
"themeResourceName": "@ThemeResourcePath@gnome-shell-theme.gresource", | ||
"enabledExtensions": ["ubuntu-dock@ubuntu.com", "ubuntu-appindicators@ubuntu.com"] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this two
if
blocks (between 106 and 112) are not necessary anymore.is_variant
is true ifvariant != light
right? So:is_variant
is true, thenvariant == 'light'
and the subdir command is equal tosubdir('light')
is_variant
is false, thenvariant != 'light'
, but subdir command is still equal tosubdir('light)
I believe this was necessary when the variantes were three (default, light and dark).