Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons: add org.gnome.Nautilus* symbolic icons and revert app-grid icon #4068

Merged
merged 1 commit into from Apr 1, 2024
Merged

icons: add org.gnome.Nautilus* symbolic icons and revert app-grid icon #4068

merged 1 commit into from Apr 1, 2024

Conversation

Muqtxdir
Copy link
Member

@Muqtxdir Muqtxdir commented Apr 1, 2024

  • split nautilus symbolic-icons into org.gnome.Nautilus directory
  • add missing symbolics
  • revert view-app-grid-symbolic (closes: GS 46: odd app grid icon #4063)

@Muqtxdir Muqtxdir requested a review from Jupi007 April 1, 2024 19:48
Jupi007
Jupi007 reviewed Apr 1, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a size difference between file-operation-cancelled-symbolic.svg and ancel-operation-symbolic.svg ? 🤔

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Apr 1, 2024 •
edited

ijust tried following the upstream symbolic pattern, they have moved icons under src/resources/icons directory, please see here

Jupi007
Jupi007 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I see why they did it like this.
LGTM 👍

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Apr 1, 2024

thanks fore review, merging1

@Muqtxdir Muqtxdir merged commit 2093dff into master Apr 1, 2024
2 of 5 checks passed
@Muqtxdir Muqtxdir deleted the refactor/nautilus-symbolic branch April 1, 2024 20:03
@3v1n0 3v1n0 mentioned this pull request Apr 17, 2024
Closed
@3v1n0 3v1n0 linked an issue Apr 17, 2024 that may be closed by this pull request
[noble] Bad Nautilus folder search icon #4055
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GS 46: odd app grid icon [noble] Bad Nautilus folder search icon
2 participants
@Muqtxdir @Jupi007