Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[noble] Bad Nautilus folder search icon #4055

Closed
fthx opened this issue Mar 7, 2024 · 12 comments · Fixed by #4068
Closed

[noble] Bad Nautilus folder search icon #4055

fthx opened this issue Mar 7, 2024 · 12 comments · Fixed by #4068

Comments

@fthx
Copy link

fthx commented Mar 7, 2024

Hi,

see this:

image

Seems to me that the search icon at the right of location field is quite bold, looks like Adwaita-styled icon?
I do use Noble with GS 45 (not 46), updated. But not latest upstream Yaru.

@Feichtmeier
Copy link
Member

Feichtmeier commented Mar 7, 2024

there are a bunch of automated PRs hanging in there, I bet the change is in there

I currently only have a very weak ubuntu machine here I use for testing my flutter snaps which I do on a mac. Will get prbly a new ubuntu machine next months hopefully.

@Jupi007 @Muqtxdir (or if my Yaru mates have no time: @3v1n0 @sergio-costas or anyone else) could you maybe check the automated PRs and merge them and merge the changes from the upstream folder into the downstream yaru folder? dont know when UI freeze is?

We def. have this icon
https://github.com/ubuntu/yaru/blob/master/icons/src/scalable/default/places/folder-saved-search-symbolic.svg
I bet just a smylink is missing here
https://github.com/ubuntu/yaru/blob/master/icons/src/symlinks/symbolic/places.list

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 8, 2024

Site Sure thing, I'll handle that before UIF

@Feichtmeier
Copy link
Member

Site thing, I'll handle that before UIF

I don't know what you mean with Site thing but I am reliefed that you take care of the upstream->yaru shell and gtk4 merges :)
I just heard today that the UIF is 21.03.

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 8, 2024

Ahaha sorry, mobile... Was supposed to be "Sure thing!" 😂

@Feichtmeier
Copy link
Member

Hi @3v1n0 I think today is UI freeze :(
Could you check if you could get all the PRs in? Paul is super busy and I still only have the crap ubuntu machine

@sergio-costas
Copy link
Contributor

I think that the problem is that Files/Nautilus has its own icon...

imagen

imagen

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 21, 2024

Could you check if you could get all the PRs in? Paul is super busy and I still only have the crap ubuntu machine

Well, maybe not strictly on time, but I'm working on them! :)

@Feichtmeier
Copy link
Member

Thank you! I will be back in the mage for 24.10 🤞

@3v1n0
Copy link
Contributor

3v1n0 commented Apr 17, 2024

I think the only way to fix this then is to patch nautilus to use a different variant on yaru, is this icon available in yaru already?

@Feichtmeier
Copy link
Member

I think the only way to fix this then is to patch nautilus to use a different variant on yaru, is this icon available in yaru already?

Yes we have this icon
https://github.com/ubuntu/yaru/blob/master/icons/src/scalable/default/org.gnome.Nautilus/nautilus-folder-search-symbolic.svg

@3v1n0
Copy link
Contributor

3v1n0 commented Apr 17, 2024

Oh, also it seems that #4068 would fix it, right?

@3v1n0
Copy link
Contributor

3v1n0 commented Apr 17, 2024

Ok, confirmed.

Schermata del 2024-04-17 20-25-43

@3v1n0 3v1n0 closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants