Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaruDetailPage: allow specifying the hero tag #553

Merged
merged 4 commits into from
Jan 20, 2023
Merged

YaruDetailPage: allow specifying the hero tag #553

merged 4 commits into from
Jan 20, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 20, 2023

No visual changes. A partial fix to #549. Something similar for YaruTitleBar comes separately.

@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Merged
@jpnurmi jpnurmi requested a review from Jupi007 January 20, 2023 09:36
Jupi007
Jupi007 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Same as your second PR :)

Jupi007
Jupi007 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

Simpler is better :D

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 20, 2023

Thanks for making me re-think what I was doing!

@jpnurmi jpnurmi merged commit 3ffcf9f into ubuntu:main Jan 20, 2023
@jpnurmi jpnurmi deleted the detail-page-hero-tag branch January 20, 2023 11:46
@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007