fix(refactor): refactor code #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avantol13
requested changes
Jul 30, 2018
| @@ -314,7 +314,7 @@ def get_primary_service_account(self, proxy_group_id): | |||
| if service_account_id_for_user in service_account_emails: | |||
| primary_email = service_account_emails[service_account_id_for_user] | |||
|
|
|||
| return self.get_service_account(primary_email) | |||
| return self.get_service_account(primary_email).json() | |||
There was a problem hiding this comment.
These are breaking changes. did you make sure you fixed every spot where these functions gets called in fence?
There was a problem hiding this comment.
this refactoring may be better off waiting until we've done more implementation, since it might be a headache to fix all the spots in fence that rely on this. I'd almost suggest we wait to do this cirrus cleanup/refactor until later
There was a problem hiding this comment.
I changed all the code called to that function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.