Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: integrate extra 'team project' validation for concept endpoints #82

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Dec 6, 2023

Jira Ticket: VADC-618

Breaking Changes

  • Endpoints that query cohorts now have an extra authorization check for "team projects", meaning the user needs specific Arborist permissions before querying a cohort

Dependency updates

  • Depends on more Arborist roles now

middlewares/auth.go Outdated Show resolved Hide resolved
@pieterlukasse pieterlukasse force-pushed the feat/integrate_arborist_validation_for_team_project branch from 9b94400 to 8c3ee95 Compare December 6, 2023 19:59
controllers/concept.go Outdated Show resolved Hide resolved
...and add respective tests
@pieterlukasse pieterlukasse marked this pull request as ready for review December 11, 2023 15:47
Base automatically changed from feat/integrate_team_project_checks to feat/team_project_feature December 13, 2023 13:58
utils/parsing.go Outdated Show resolved Hide resolved
...which is cohort_definition_id...there is no such thing as "cohort id"
Copy link
Contributor

@tianj7 tianj7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pieterlukasse pieterlukasse merged commit 198efbf into feat/team_project_feature Dec 14, 2023
11 checks passed
@pieterlukasse pieterlukasse deleted the feat/integrate_arborist_validation_for_team_project branch December 14, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants