Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-8364 fix: strict csp #893

Merged
merged 8 commits into from
Jul 28, 2021
Merged

PXP-8364 fix: strict csp #893

merged 8 commits into from
Jul 28, 2021

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Jul 20, 2021 •
edited
Loading

Jira Ticket: PXP-8364

Remove CSP connect-src: https://*.s3.amazonaws.com https://*.mapbox.com to tighten the scope

Improvements

  • Misc: change CSP for mapbox according to this guide
  • Misc: change CSP connect-src: https://*.s3.amazonaws.com to connect-src: https://<DATA_UPLOAD_BUCKET_NAME>.s3.amazonaws.com

Deployment changes

@mfshao mfshao changed the title fix: strict csp PXP-8364 fix: strict csp Jul 23, 2021
@mfshao mfshao marked this pull request as ready for review July 23, 2021 20:51
mfshao
mfshao commented Jul 23, 2021
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
@mfshao mfshao merged commit f00be78 into master Jul 28, 2021
@mfshao mfshao deleted the fix/csp branch July 28, 2021 19:53
@mfshao mfshao mentioned this pull request Aug 16, 2021
Merged
This was referenced Sep 3, 2021
Merged
Closed
Merged
Closed
Closed
Closed
Closed
This was referenced Sep 14, 2021
Merged
Merged
Merged
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Nov 29, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Dec 10, 2021
Closed
This was referenced Jan 10, 2022
Merged
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jan 20, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 3, 2022
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 2, 2022
Merged
This was referenced Mar 21, 2022
Merged
Merged
Merged
This was referenced Mar 29, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2022
Closed
Closed
This was referenced Jun 23, 2022
Closed
Closed
@PlanXCyborg PlanXCyborg mentioned this pull request Jul 21, 2022
Open
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 14, 2022
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Oct 21, 2022
Closed
This was referenced Dec 19, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nhawk m0nhawk m0nhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfshao @m0nhawk