Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-8520 Feat/paymodels #900

Merged
merged 16 commits into from
Nov 3, 2021
Merged

PXP-8520 Feat/paymodels #900

merged 16 commits into from
Nov 3, 2021

Conversation

mfshao
Copy link
Collaborator

@mfshao mfshao commented Jul 28, 2021

Jira Ticket: PXP-8520

Display user pay model information in a banner on top of the workspace page

Only visible if the current user has a pay model setup according to Hatchery

Screen Shot 2021-07-28 at 12 04 01 PM

Improvements

  • Workspace: display user pay model information (if available) in a banner on top of the workspace page
  • Workspace: external login options hint banner will only display if user has any unconnected options

Deployment changes

@mfshao mfshao marked this pull request as draft July 30, 2021 14:03
payModel: data,
});
}, 30000);
this.setState({ payModelInterval });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkWorkspacePayModel doesn't really need to be a periodical job for now

but it will be needed once we really stores and fetches the value of cost from DB

@mfshao mfshao marked this pull request as ready for review November 1, 2021 18:56
Copy link
Contributor

@ocshawn ocshawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, dont know if it should refresh every 30s, but i am not familiar enough with the usage

@mfshao
Copy link
Collaborator Author

mfshao commented Nov 3, 2021

looks good to me, dont know if it should refresh every 30s, but i am not familiar enough with the usage

Yes, the current information that got displayed on this banner don't need auto-refreash, but will be needed once we have the cost/remaining balance info in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants