Skip to content

Commit

Permalink
fix(passport): don't close session as it needs to be used downstream
Browse files Browse the repository at this point in the history
  • Loading branch information
Avantol13-machine-user committed Jan 25, 2022
1 parent 7d4edaa commit 7ad2256
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fence/blueprints/login/ras.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ def post_login(self, user=None, token_result=None, id_from_idp=None):
# do an on-the-fly usersync for this user to give them instant access after logging in through RAS
# if GLOBAL_PARSE_VISAS_ON_LOGIN is true then we want to run it regardless of whether or not the client sent parse_visas on request
if parse_visas:
# Close previous db sessions. Leaving it open causes a race condition where we're
# viewing user.project_access while trying to update it in usersync
# not closing leads to partially updated records
current_session.close()

# get passport then call sync on it
try:
passport = (
Expand Down

0 comments on commit 7ad2256

Please sign in to comment.