fix(refresh_tokens): ensure deletion of expired tokens from the database

[Avantol13]

New Features

Breaking Changes

Bug Fixes

Improvements

• ensure deletion of expired tokens from the database

Dependency updates

Deployment changes

[coveralls]

Pull Request Test Coverage Report for Build 13129

• 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 73.919%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
fence/resources/openid/idp_oauth2.py	0	6	0.0%

Totals
Change from base Build 13114:	-0.02%
Covered Lines:	6890
Relevant Lines:	9321

---

💛 - Coveralls

[paulineribeyre]

should we sort the tokens from oldest to newest to make sure the old ones get cleaned up?

[Avantol13]

this doesn't break on the first one it finds, it goes through all of them. So either way they'll all get cleaned up

[paulineribeyre]

but it resets refresh_token to None, so if it finds a valid token and then an expired token, it will raise the AuthError when it shouldn't

[Avantol13]

Ohh, I misunderstood what you were saying. Good catch, yeah I'll need to make another PR. Ideally there's only ever 1 expired at a time but this might be problematic for the current state