Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbenvvar): db connection info from env #1060

Merged
merged 4 commits into from
Dec 8, 2022
Merged

feat(dbenvvar): db connection info from env #1060

merged 4 commits into from
Dec 8, 2022

Conversation

jawadqur
Copy link
Contributor

Jira Ticket: PXP-xxxx

  • Remove this line if you've changed the title to (PXP-xxxx): <title>

New Features

Ability to add DB connection string via environment variable

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@coveralls
Copy link

coveralls commented Nov 29, 2022

Pull Request Test Coverage Report for Build 13189

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 74.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/config.py 2 4 50.0%
Totals Coverage Status
Change from base Build 13183: -0.01%
Covered Lines: 6949
Relevant Lines: 9386

💛 - Coveralls

fence/config.py Outdated Show resolved Hide resolved
paulineribeyre
paulineribeyre previously approved these changes Dec 6, 2022
@jawadqur jawadqur merged commit d3c4075 into master Dec 8, 2022
@jawadqur jawadqur deleted the feat/dbenvvar branch December 8, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants