Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fence-create google-bucket-create #1077

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Mar 8, 2023

[2023-03-08 22:20:53,211][fence.scripting.fence_create][   INFO] No project with auth_id QA found. No linking occured.
Traceback (most recent call last):
  File "/usr/local/bin/fence-create", line 6, in <module>
    sys.exit(main())
  File "/fence/bin/fence_create.py", line 536, in main
    create_or_update_google_bucket(
  File "/fence/fence/scripting/fence_create.py", line 1360, in create_or_update_google_bucket
    bucket_db_entry = _create_or_update_google_bucket_and_db(
  File "/fence/fence/scripting/fence_create.py", line 1505, in _create_or_update_google_bucket_and_db
    project_id=project_db_entry.id, provider_id=google_cloud_provider.id
AttributeError: 'NoneType' object has no attribute 'id'

Bug Fixes

  • Fix fence-create google-bucket-create when the project does not exist

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13330

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 74.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/scripting/fence_create.py 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
fence/scripting/fence_create.py 1 60.18%
fence/resources/ga4gh/passports.py 2 87.43%
Totals Coverage Status
Change from base Build 13320: 0.0%
Covered Lines: 7139
Relevant Lines: 9578

💛 - Coveralls

@paulineribeyre paulineribeyre removed the test-google-googleDataAccessTest setting label to retry specific feature label Mar 9, 2023
@paulineribeyre paulineribeyre merged commit ccea801 into master Mar 9, 2023
@paulineribeyre paulineribeyre deleted the fix/google-bucket-create branch March 9, 2023 23:45
grugna added a commit to chicagopcdc/fence that referenced this pull request Mar 14, 2023
Fix fence-create google-bucket-create (uc-cdis#1077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants