Remove Travis, add GH Action for Unit Test #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-burt-uch
force-pushed
the
feat/remove-travis-for-gh-actions
branch
2 times, most recently
from
29b1f76
to
6147b9b
Compare
PlanXCyborg
added
test-apis-centralizedAuth
test-apis-dbgapTest
test-portal-dataUploadTest
and removed
@requires-fence
labels
k-burt-uch
force-pushed
the
feat/remove-travis-for-gh-actions
branch
from
5c84057
to
dec237b
Compare
k-burt-uch
force-pushed
the
feat/remove-travis-for-gh-actions
branch
from
dec237b
to
d077329
Compare
paulineribeyre
previously approved these changes
Nov 6, 2023
Change test db to postgres Adding code coverage Fix coverage report
k-burt-uch
force-pushed
the
feat/remove-travis-for-gh-actions
branch
from
d077329
to
93eaf38
Compare
k-burt-uch
commented
Jun 13, 2024
.github/workflows/ci.yaml
Outdated
| ci: | ||
| name: Build Image and Push | ||
| # TODO Add this line back once we update to Python 3.9 from 3.6 | ||
| # needs: Security | ||
| needs: Security |
There was a problem hiding this comment.
Do we still need this?
There was a problem hiding this comment.
i think so - it means we don't build and push if the security check did not succeed. (arguably not great for development, but 🤷♀️ )
There was a problem hiding this comment.
its easy to remove if it becomes a barrier.
|
This fell through the cracks :( The python unit tests are now passing, so this is technically done but I'm not sure if the security flag on the docker push is necessary. |
paulineribeyre
previously approved these changes
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes