feat(public-files): check authz/acl field, then hit arborist as anon … #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to see if file is public
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 7147
💛 - Coveralls |
rudyardrichter
suggested changes
Jun 27, 2019
fence/blueprints/data/indexd.py
Outdated
| @@ -365,7 +367,7 @@ def metadata(self): | |||
|
|
|||
| @cached_property | |||
| def public(self): | |||
| return check_public(self.set_acls) | |||
| return check_public(self.authz) | |||
There was a problem hiding this comment.
a couple thoughts:
check_publiconly used here so this would be a good opportunity to inline- should keep the ACLs check here too I think—we can use
authzif exists or default to acl
There was a problem hiding this comment.
oh, this is perhaps misleading, the cached property isn't just authz, it'll get acl field if authz doesn't exist. I will inline check_public tho
rudyardrichter
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes