Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upsert): upsert policies #699

Merged
merged 4 commits into from
Sep 23, 2019
Merged

fix(upsert): upsert policies #699

merged 4 commits into from
Sep 23, 2019

Conversation

vpsx
Copy link
Contributor

@vpsx vpsx commented Sep 20, 2019

Usersync needs to upsert policies, not create-and-skip-if-exist.
Therefore, in usersync, instead of create_policy, use update_policy with create_if_not_exist set to True
corrects #698

also bump gen3authz to 0.2.2 and update mocks

Bug Fixes

in usersync, upsert policies instead of create-and-skip-if-exist. corrects #698

@github-actions
Copy link

github-actions bot commented Sep 20, 2019

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Sep 20, 2019

Pull Request Test Coverage Report for Build 7700

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.88%

Totals Coverage Status
Change from base Build 7678: 0.0%
Covered Lines: 4951
Relevant Lines: 7085

💛 - Coveralls

@vpsx vpsx changed the title WIP fix(upsert): upsert policies fix(upsert): upsert policies Sep 20, 2019
@vpsx vpsx merged commit 025a81c into master Sep 23, 2019
@vpsx vpsx deleted the fix/upsert branch September 23, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants