Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login-options): fix backwards compatible config #724

Merged
merged 1 commit into from
Oct 23, 2019
Merged

fix(login-options): fix backwards compatible config #724

merged 1 commit into from
Oct 23, 2019

Conversation

paulineribeyre
Copy link
Contributor

Bug Fixes

  • Fix LOGIN_OPTIONS/ENABLED_IDENTITY_PROVIDERS fence-config backwards compatibility

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7981

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.436%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/login/init.py 1 2 50.0%
Totals Coverage Status
Change from base Build 7979: 0.0%
Covered Lines: 5073
Relevant Lines: 7306
💛 - Coveralls

@Avantol13
Copy link
Contributor

I reran your tests

@paulineribeyre paulineribeyre merged commit 65540bf into master Oct 23, 2019
@paulineribeyre paulineribeyre deleted the fix/login-options branch October 23, 2019 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avantol13 Avantol13 Avantol13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulineribeyre @coveralls @Avantol13