Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login-options): fix backwards compatible config #727

Merged
merged 5 commits into from
Oct 29, 2019
Merged

fix(login-options): fix backwards compatible config #727

merged 5 commits into from
Oct 29, 2019

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Oct 28, 2019 •
edited

Bug Fixes

  • Fix LOGIN_OPTIONS/ENABLED_IDENTITY_PROVIDERS fence-config backwards compatibility
  • Fix Fence multi-tenant login by always using the IDP query parameter

@github-actions
Copy link

github-actions bot commented Oct 28, 2019 •
edited

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited

Pull Request Test Coverage Report for Build 8035

  • 4 of 10 (40.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 69.446%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/login/shib.py 0 1 0.0%
fence/blueprints/login/fence_login.py 2 7 28.57%
Totals Coverage Status
Change from base Build 7999: -0.02%
Covered Lines: 5080
Relevant Lines: 7315
💛 - Coveralls

@Avantol13 Avantol13 merged commit 056b984 into master Oct 29, 2019
@Avantol13 Avantol13 deleted the fix/login-options branch October 29, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avantol13 Avantol13 Avantol13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulineribeyre @coveralls @Avantol13