Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signed-urls): use ONLY authz when available to determine if file … #740

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Avantol13
Copy link
Contributor

New Features

Breaking Changes

Bug Fixes

  • Fix bug where if acl field in indexd had * but authz field restricted access, we assumed the file was public
  • Fix bug where google requester pays group didnt' get passed into correct function to append info to the signed url

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

github-actions bot commented Dec 6, 2019

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Dec 6, 2019

Pull Request Test Coverage Report for Build 8555

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 69.462%

Totals Coverage Status
Change from base Build 8552: 0.004%
Covered Lines: 5136
Relevant Lines: 7394

💛 - Coveralls

Copy link
Contributor

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants