PXP-4582 user sync merges multiple dbgap sftp servers #755
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 8449
💛 - Coveralls |
|
rn |
Yep completely missed that. I think it makes sense that integration tests are not failing since we don't have any integration tests for multiple sftp support and the rest of the code should work as is without |
fence/config-default.yaml
Outdated
| # Follows the same format as dbGaP entries | ||
| # accepts a list of objects | ||
| # example: | ||
| # additional_dbGaP: |
There was a problem hiding this comment.
you can make dbGaP a list of 1 element in the default config
| user_projects_csv = { | ||
| key.lower(): value for key, value in user_projects_csv.items() | ||
| } | ||
| user_projects = {key.lower(): value for key, value in user_projects.items()} |
There was a problem hiding this comment.
i think we need this line
DCF will be checking 2 sftp servers for telemetry files and merge user credentials from both. This PR allows for the configuration of any number of additional dbGaP servers in fence's config file by including a list of dbGaP objects.
In order to have this work on DCF, we will have to modify DCF's fence config file to include a list of
dbGaPconfigurations