Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(google): keep track of user access per group and do a "bulk" upd… #795

Merged
merged 9 commits into from
Jul 16, 2020
Merged

feat(google): keep track of user access per group and do a "bulk" upd… #795

merged 9 commits into from
Jul 16, 2020

Conversation

Avantol13
Copy link
Contributor

…ate per group with smarter diff

New Features

  • (new optional configuration) Google Group syncing for usersync can keep track of all groups and users and do one "bulk" update at the end (instead of per user) with a smart diff of expected vs actual group membership in google

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Jul 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 9275

  • 18 of 53 (33.96%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 69.346%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/sync/sync_users.py 9 13 69.23%
fence/resources/storage/init.py 8 21 38.1%
fence/resources/google/access_utils.py 1 19 5.26%
Totals Coverage Status
Change from base Build 9271: -0.3%
Covered Lines: 5314
Relevant Lines: 7663
💛 - Coveralls

vpsx
vpsx approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@vpsx vpsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a question and some suggestions

fence/resources/google/access_utils.py Outdated Show resolved Hide resolved
fence/resources/storage/__init__.py Show resolved Hide resolved
fence/config-default.yaml Show resolved Hide resolved
@themarcelor themarcelor added the test-google-googleDataAccessTest setting label to retry specific feature label Jul 14, 2020
@Avantol13 Avantol13 merged commit 5128b8c into master Jul 16, 2020
@Avantol13 Avantol13 deleted the feat/googlesync branch July 16, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpsx vpsx vpsx approved these changes

Assignees
No one assigned
Labels
test-google-googleDataAccessTest setting label to retry specific feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Avantol13 @coveralls @vpsx @themarcelor @Avantol13-machine-user