Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-7529: sign download urls where no_force_sign=False #873

Merged
merged 4 commits into from
Feb 23, 2021
Merged

PXP-7529: sign download urls where no_force_sign=False #873

merged 4 commits into from
Feb 23, 2021

Conversation

mcannalte
Copy link
Contributor

Bug Fixes

  • checks the value of no_force_sign query parameter on /user/data/download/<guid> and proceeds to sign urls where this value is false

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@mcannalte mcannalte changed the title Fix/no force sign PXP-7529: sign download urls where no_force_sign=False Feb 11, 2021
@mcannalte mcannalte marked this pull request as ready for review February 12, 2021 17:52
@mcannalte
#):
d9acf1f 
fix(no_force_sign): add regression test for urls with no_force_sign=False
@mcannalte
fix(no_force_sign): parse truthiness from no_force_sign param, rather…
aa5584d 
… than check if exists
paulineribeyre
paulineribeyre approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcannalte mcannalte removed the request for review from Avantol13 February 22, 2021 15:48
@coveralls
Copy link

coveralls commented Feb 22, 2021 •
edited

Pull Request Test Coverage Report for Build 10438

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 69.282%
Totals Coverage Status
Change from base Build 10436: 0.004%
Covered Lines: 5695
Relevant Lines: 8220
💛 - Coveralls

@mcannalte mcannalte merged commit 605378f into master Feb 23, 2021
@mcannalte mcannalte deleted the fix/no_force_sign branch February 23, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcannalte @coveralls @paulineribeyre @Avantol13