Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Parse URL for RAS #895

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Fix Parse URL for RAS #895

merged 2 commits into from
Apr 8, 2021

Conversation

BinamB
Copy link
Contributor

@BinamB BinamB commented Apr 7, 2021

Bug Fixes

  • Fix parsing for redirect url in RAS

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@BinamB BinamB changed the title Fix/parsae urls Fix Parse URL for RAS Apr 7, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10688

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 70.444%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/login/ras.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
fence/blueprints/login/ras.py 1 67.27%
Totals Coverage Status
Change from base Build 10685: 0.007%
Covered Lines: 5887
Relevant Lines: 8357
💛 - Coveralls

@BinamB BinamB merged commit 256c724 into master Apr 8, 2021
@BinamB BinamB deleted the fix/parsae_urls branch April 8, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BinamB @coveralls @paulineribeyre